Improve PayloadConverter javadoc regarding providing of EncodingKeys#METADATA_ENCODING_KEY#702
Merged
Spikhalskiy merged 2 commits intotemporalio:masterfrom Sep 9, 2021
Conversation
…METADATA_ENCODING_KEY
Spikhalskiy
requested review from
Sushisource,
mfateev and
vitarb
as code owners
Sushisource
reviewed
Sep 8, 2021
Sushisource
approved these changes
Sep 8, 2021
…dConverter.java Co-authored-by: Spencer Judge <sjudge@hey.com>
vitarb
approved these changes
Sep 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PayloadConverterjavadoc is improved to provide information about an importantEncodingKeys#METADATA_ENCODING_KEYfunctionality that implementers of custom converters should keep in mind.Minor fixes of formats of javadocs in other classes
EncodingKeys#METADATA_ENCODING_KEYmade public